From 5f49a784022d8f35385431684c7141ccacd10b8f Mon Sep 17 00:00:00 2001 From: Randy Dunlap Date: Thu, 14 Aug 2003 11:28:33 -0700 Subject: [PATCH] [PATCH] janitor: floppy: use register_blkdev return value From: Daniele Bellucci On failure register_blkdev doesn't necessarly return -ENODEV .. it can return -ENOMEM too. This patch add a little better audit of register_blkdev. --- drivers/block/floppy.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index 1a7ba629951ab..4e36e61e7cfb8 100644 --- a/drivers/block/floppy.c +++ b/drivers/block/floppy.c @@ -135,6 +135,10 @@ * requires many non-obvious changes in arch dependent code. */ +/* 2003/07/28 -- Daniele Bellucci . + * Better audit of register_blkdev. + */ + #define FLOPPY_SANITY_CHECK #undef FLOPPY_SILENT_DCL_CLEAR @@ -4260,10 +4264,8 @@ int __init floppy_init(void) } devfs_mk_dir ("floppy"); - if (register_blkdev(FLOPPY_MAJOR,"fd")) { - err = -EBUSY; + if ((err = register_blkdev(FLOPPY_MAJOR,"fd"))) goto out; - } floppy_queue = blk_init_queue(do_fd_request, &floppy_lock); blk_queue_max_sectors(floppy_queue, 64); -- 2.53.0