From 67a0713cb21baf473279b337b91c0e66e1261685 Mon Sep 17 00:00:00 2001 From: Jeff Garzik Date: Fri, 5 Dec 2003 07:32:14 -0800 Subject: [PATCH] [PATCH] fix use-after-free in libata Fixes oops some were seeing on module unload. Caught by Jon Burgess. --- drivers/scsi/libata-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c index b92d67726018f..82ab1607275c8 100644 --- a/drivers/scsi/libata-core.c +++ b/drivers/scsi/libata-core.c @@ -3224,8 +3224,6 @@ void ata_pci_remove_one (struct pci_dev *pdev) scsi_host_put(ap->host); /* FIXME: check return val */ } - kfree(host_set); - pci_release_regions(pdev); for (i = 0; i < host_set->n_ports; i++) { @@ -3242,6 +3240,7 @@ void ata_pci_remove_one (struct pci_dev *pdev) } } + kfree(host_set); pci_disable_device(pdev); pci_set_drvdata(pdev, NULL); } -- 2.53.0