From 69f5a5c866227a2f1476b07db76077407e9f5c41 Mon Sep 17 00:00:00 2001 From: James Bottomley Date: Thu, 25 Sep 2003 00:41:58 -0700 Subject: [PATCH] [PATCH] fix smc-mca cleanup breakage The latest set of smc-mca fixes broke the driver. Apparently, it wasn't realised that request_region() actually returns a pointer to the region you're requesting if it can. Without this fix, the smc-mca cannot attach to any device. --- drivers/net/smc-mca.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/smc-mca.c b/drivers/net/smc-mca.c index c5a0857073024..b9dc4a31700ec 100644 --- a/drivers/net/smc-mca.c +++ b/drivers/net/smc-mca.c @@ -269,9 +269,10 @@ int __init ultramca_probe(struct device *gen_dev) goto err_unregister_netdev; } - rc = request_region(ioaddr, ULTRA_IO_EXTENT, dev->name); - if (rc) + if (!request_region(ioaddr, ULTRA_IO_EXTENT, dev->name)) { + rc = -ENODEV; goto err_unregister_netdev; + } reg4 = inb(ioaddr + 4) & 0x7f; outb(reg4, ioaddr + 4); -- 2.53.0