From 78654ea75992a8e0273f7bb2783177cc1e6b92b4 Mon Sep 17 00:00:00 2001 From: "David S. Miller" Date: Tue, 4 Nov 2003 22:46:25 -0800 Subject: [PATCH] [TG3]: Fix bugs in ETHTOOL_SSET introduced by ethtool_ops conversion. - Missing spin_lock*() calls before tp->link_config twiddling. - Missing assignment to tp->link_config.autoneg --- drivers/net/tg3.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 92b59780aca99..68a6316632fb2 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -5935,6 +5935,10 @@ static int tg3_set_settings(struct net_device *dev, struct ethtool_cmd *cmd) tp->link_config.phy_is_low_power) return -EAGAIN; + spin_lock_irq(&tp->lock); + spin_lock(&tp->tx_lock); + + tp->link_config.autoneg = cmd->autoneg; if (cmd->autoneg == AUTONEG_ENABLE) { tp->link_config.advertising = cmd->advertising; tp->link_config.speed = SPEED_INVALID; -- 2.53.0