From 9d6697b6ddc5adf80c05583cd100b9e18893ea68 Mon Sep 17 00:00:00 2001 From: Alan Cox Date: Wed, 26 Mar 2003 18:02:37 -0800 Subject: [PATCH] [PATCH] Add a comment that the irq_nosync stuff needs revisiting --- drivers/ide/ide-iops.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/ide/ide-iops.c b/drivers/ide/ide-iops.c index 7c7a5ac53aa61..56f991a8d88bb 100644 --- a/drivers/ide/ide-iops.c +++ b/drivers/ide/ide-iops.c @@ -903,6 +903,14 @@ int ide_config_drive_speed (ide_drive_t *drive, u8 speed) * Select the drive, and issue the SETFEATURES command */ disable_irq_nosync(hwif->irq); + + /* + * FIXME: we race against the running IRQ here if + * this is called from non IRQ context. If we use + * disable_irq() we hang on the error path. Work + * is needed. + */ + udelay(1); SELECT_DRIVE(drive); SELECT_MASK(drive, 0); -- 2.53.0