From 9e3a8956b8984544013b653778adc12b9a4871ab Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Tue, 9 Sep 2003 10:21:46 -0700 Subject: [PATCH] [PATCH] CPU scheduler CAN_MIGRATE fix From: Andrew Theurer This change: http://linux.bkbits.net:8080/linux-2.5/diffs/kernel/sched.c@1.202 does not seem to make sense: #define CAN_MIGRATE_TASK(p,rq,this_cpu) \ ((!idle || (jiffies - (p)->last_run > cache_decay_ticks)) && \ !task_running(rq, p) && \ cpu_isset(this_cpu, (p)->cpus_allowed)) It should be just the opposite; an idle cpu should be able to have a more aggressive steal, and a busy cpu should not. --- kernel/sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched.c b/kernel/sched.c index 51241d70f924f..89f1bb28dacdc 100644 --- a/kernel/sched.c +++ b/kernel/sched.c @@ -1064,7 +1064,7 @@ skip_queue: */ #define CAN_MIGRATE_TASK(p,rq,this_cpu) \ - ((!idle || (jiffies - (p)->last_run > cache_decay_ticks)) && \ + ((idle || (jiffies - (p)->last_run > cache_decay_ticks)) && \ !task_running(rq, p) && \ cpu_isset(this_cpu, (p)->cpus_allowed)) -- 2.53.0