From bdf29b0abe1792ab0d6caa8e95b852d4ab4f9ece Mon Sep 17 00:00:00 2001 From: Dave Kleikamp Date: Wed, 29 Oct 2003 04:05:37 -0600 Subject: [PATCH] JFS: remove racy, redundant call to block_invalidatepage __invalidate_metapages references mp->page after after releasing the meta_lock spinlock, without increasing the use count. This is racy and unnecessary since setting the META_discard flag is sufficient. block_invalidatepage() will be called when the metapage is released. --- fs/jfs/jfs_metapage.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c index a8100967e1963..84742dc9c57d2 100644 --- a/fs/jfs/jfs_metapage.c +++ b/fs/jfs/jfs_metapage.c @@ -511,9 +511,6 @@ void __invalidate_metapages(struct inode *ip, s64 addr, int len) if (mp) { set_bit(META_discard, &mp->flag); spin_unlock(&meta_lock); - lock_page(mp->page); - block_invalidatepage(mp->page, 0); - unlock_page(mp->page); } else { spin_unlock(&meta_lock); page = find_lock_page(mapping, lblock>>l2BlocksPerPage); -- 2.53.0