From d597f71b51b3c1b1a2d3290aa3e731f4e8c2207f Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Wed, 2 Apr 2003 16:26:34 -0800 Subject: [PATCH] [PATCH] Fix some compile warnings From: "Martin J. Bligh" Fix a couple of instances of "warning: suggest parentheses around assignment used as truth value". --- drivers/base/cpu.c | 8 ++++++-- drivers/base/memblk.c | 8 ++++++-- drivers/base/node.c | 8 ++++++-- 3 files changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c index 5d35a324e0191..a5d65dc4eff79 100644 --- a/drivers/base/cpu.c +++ b/drivers/base/cpu.c @@ -49,8 +49,12 @@ int __init register_cpu(struct cpu *cpu, int num, struct node *root) int __init cpu_dev_init(void) { int error; - if (!(error = devclass_register(&cpu_devclass))) - if ((error = driver_register(&cpu_driver))) + + error = devclass_register(&cpu_devclass); + if (!error) { + error = driver_register(&cpu_driver); + if (error) devclass_unregister(&cpu_devclass); + } return error; } diff --git a/drivers/base/memblk.c b/drivers/base/memblk.c index 350078bd30b0f..676c6f26ffcda 100644 --- a/drivers/base/memblk.c +++ b/drivers/base/memblk.c @@ -50,9 +50,13 @@ int __init register_memblk(struct memblk *memblk, int num, struct node *root) int __init register_memblk_type(void) { int error; - if (!(error = devclass_register(&memblk_devclass))) - if (error = driver_register(&memblk_driver)) + + error = devclass_register(&memblk_devclass); + if (!error) { + error = driver_register(&memblk_driver); + if (error) devclass_unregister(&memblk_devclass); + } return error; } postcore_initcall(register_memblk_type); diff --git a/drivers/base/node.c b/drivers/base/node.c index cfcf117018dc0..e08b7c5f208e9 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -92,9 +92,13 @@ int __init register_node(struct node *node, int num, struct node *parent) int __init register_node_type(void) { int error; - if (!(error = devclass_register(&node_devclass))) - if (error = driver_register(&node_driver)) + + error = devclass_register(&node_devclass); + if (!error) { + error = driver_register(&node_driver); + if (error) devclass_unregister(&node_devclass); + } return error; } postcore_initcall(register_node_type); -- 2.53.0