X-Git-Url: http://git.hungrycats.org/cgi-bin/gitweb.cgi?p=xscreensaver;a=blobdiff_plain;f=driver%2Fsubprocs.c;h=910d5cc92912bacc819fcbad128faff93a237981;hp=62ae9ae9040281054a50711acfd5b0c5ae395a04;hb=cccbddbc4140cf9a06d7d95cc5c0ca36eb5d6e28;hpb=a94197e76a5dea5cb60542840809d6c20d0abbf3 diff --git a/driver/subprocs.c b/driver/subprocs.c index 62ae9ae9..910d5cc9 100644 --- a/driver/subprocs.c +++ b/driver/subprocs.c @@ -732,8 +732,8 @@ spawn_screenhack_1 (saver_screen_info *ssi, Bool first_time_p) */ if (p->verbose_p) fprintf(stderr, - "%s: no suitable visuals for these programs.\n", - blurb()); + "%s: %d: no programs enabled, or no suitable visuals.\n", + blurb(), ssi->number); return; } else @@ -885,6 +885,11 @@ hack_environment (saver_info *si) if (putenv (npath)) abort (); + + /* don't free (npath) -- some implementations of putenv (BSD 4.4, + glibc 2.0) copy the argument, but some (libc4,5, glibc 2.1.2) + do not. So we must leak it (and/or the previous setting). Yay. + */ } #endif /* HAVE_PUTENV && DEFAULT_PATH_PREFIX */ } @@ -923,6 +928,7 @@ hack_subproc_environment (saver_screen_info *ssi) #ifdef HAVE_PUTENV if (putenv (ndpy)) abort (); + /* do not free(ndpy) -- see above. */ #endif /* HAVE_PUTENV */ }